[kmymoney4] [Bug 372786] New: Can't import some investments on KF5

[allan]

https://bugs.kde.org/show_bug.cgi?id=372786

            Bug ID: 372786
           Summary: Can't import some investments on KF5
           Product: kmymoney4
           Version: git (master)
          Platform: Kubuntu Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: csvimporter
          Assignee: kmymoney-devel at kde.org
          Reporter: agander93 at gmail.com
  Target Milestone: ---

On completing the CSV importer fields/columns, when I clicked Import,
the account selector showed only checking accounts.


This is the result of a recent code change circa line 646 in
MyMoneyStatementReader::processTransactionEntry() -
"
if (brokerageactid.isEmpty()) {
      brokerageactid = SelectBrokerageAccount();
  }"
as it supplies a checking account for the investment account import.  On
removing this code change, the import completed, but without any
account selection being offered.

In my case, KMM choses to import into an account which happens to be closed. 
The user needs to be able to select the account into which to import, as a
security/stock could be present in more than one investment account.  The
importing CSV file cannot know what the user requires.

To avoid importing into a closed account, I've added a test for closed accounts
 circa line 468 in csvwizard() -
"if ((statementHeader.contains(txt, Qt::CaseInsensitive)) &&
(!(*account).isClosed()))"

The import now proceeds and produces the account selection dialog, as required.

-- 
You are receiving this mail because:
You are the assignee for the bug.