Review Request 129371: [kmymoney/4.8] Use GpgME++ if possible, QGpgme from kdepimlibs-4 as fallback

[Jack Ostroff]

> On Nov. 11, 2016, 8:38 p.m., Marko Käning wrote:
> > Cool, does this mean, that one won't need kdepimlibs anymore when building KMM? :-)
> 
> Andreas Sturmlechner wrote:
>     Yes, please give it some testing ;)
> 
> Marko Käning wrote:
>     Can't promise when, but will give KMM4 some testing on OSX/macOS. Thanks for implementing this!
> 
> Jack Ostroff wrote:
>     With gpgme 1.7.1, gpgmepp 16.04.3, and kdepimlibs 4.14.11_pre20160211_r2 (Gentoo version) it fails to find gpgmepp.  It says it considered but did not accept /usr/lib64/gpgmepp/GpgmeppConfig.cmake.  That belongs to kdepimlibs.  Should it have continued looking?  I don't want to actually uninstall kdepimlibs until I know I can work without it.  Is that possible?
> 
> Andreas Sturmlechner wrote:
>     That's expected, Gpgmepp is only found if you built gpgme-1.7.1[cxx] which is blocking kdepimlibs:4. If the latter is present instead, it will use its QGpgmeConfig.cmake as it has always done (even though only using the gpgmepp part from kdepimlibs).
>     
>     Take a look at https://github.com/gentoo/gentoo/pull/2667 which adds USE=pim to kmymoney-4.8.0 to toggle between building with gpgme-1.7.1[cxx] or kdepimlibs:4.
> 
> Jack Ostroff wrote:
>     Ah - I didn't have cxx set.  So there is no way for me to test this without unmerging kdepimlibs.  I suppose I can do a quickpkg so I can put it back quickly if necessary.  Right now I just want to be sure it works.  I'm already using a mix of portage ebuilds (main tree, kde overaly, and local modifications) as well as some builds without using portage at all.  I mostly keep track of what's what, but I do trip over my own feet on occasion.  It will be great when I can get back to all in-tree ebuilds.  (Sorry for the Gentoo specific digression.)
> 
> Jack Ostroff wrote:
>     (Gentoo specific problem) I've been struggling with getting gpgme to accept the qt5 and cxx use flags.  /usr/portage/base/package.use.mask includes the following three lines:
>     # Alon Bar-Lev <alonbl at gentoo.org> (23 Sep 2016)
>     # Mask qt5 until kde ports
>     app-crypt/gpgme cxx qt5
>     
>     I don't understand the reasoning and whether or not it's safe to unblock them.  Thanks for any explanations.
> 
> Andreas Sturmlechner wrote:
>     [Gentoo excursion] echo "app-crypt/gpgme -cxx -qt5" >> /etc/portage/profile/package.use.mask
>     
>     This is just a safeguard so that most blockers (against old PIM) are sorted out before >=gpgme-1.7.0 is let loose on the tree. You're safe.

Success.  builds and works fine with gpgme-1.7.1 and no kdepimlibs, with the Gentoo 2667 patch.  (Not tested super extensively, but I did several OFX direct connect downloads.)


- Jack


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129371/#review100789
-----------------------------------------------------------


On Nov. 10, 2016, 6:13 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129371/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2016, 6:13 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Gives kmymoney-4 some extended life on systems that upgrade to KDE Applications 16.12 and are required to upgrade to kdepimlibs-conflicting GpgME-1.7.0 by the latest version of KDE PIM.
> 
> Remove bogus qgpgme include.
> Make kdepimlibs optional (based on b5de50ccaa1571c4feb0c17ea8016554e3b822d7 from master)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 22515185dcb2bdb6a9027101270ff97d445008b6 
>   kmymoney/dialogs/settings/ksettingsschedules.cpp da138a7ab138d2f5ef1e8f5b7ad636f9a1964343 
>   kmymoney/kmymoney.cpp a4251f031cee280983aa67c55447d3f97865dcbd 
>   libkdchart/kdablibfakes/src/KDABLibFakes.h f47ec24423a2ca61b04a98069351539e738fe572 
>   libkgpgfile/CMakeLists.txt a41a6a408e3da8769308dae75d4f514aa969dc87 
>   libkgpgfile/kgpgfile.cpp b1870be92edb833ed30f369e3e0ca0f320fe147b 
> 
> Diff: https://git.reviewboard.kde.org/r/129371/diff/
> 
> 
> Testing
> -------
> 
> Built successfully (so far only tested with GpgME++ 1.7.1 and without kdepimlibs-4).
> Also built fine on a system with Gpgme 1.7.1 (no Gpgmepp bindings) and kdepimlibs-4 installed.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20161119/6ea2e9a0/attachment.html>