Review Request 124957: Bug 351874 - QIF import of investment buys and sells mishandles commissions

[Łukasz Wojniłowicz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124957/#review95669
-----------------------------------------------------------



I tested fourth revision of patch; it works for me. With my patch from review #127983, it will be required to completely fix bug #351874. Therefore I would like to apply it to master branch in near future. Please post your objections here in case I shouldn't do that.

- Łukasz Wojniłowicz


On Sept. 1, 2015, 12:05 a.m., Jeff Lundblad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124957/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 12:05 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 351874
>     http://bugs.kde.org/show_bug.cgi?id=351874
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Changes made so that the commission for an investment buy or sell is only added to the transaction total one time instead of three times.
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneyqifreader.cpp d07b9b9 
> 
> Diff: https://git.reviewboard.kde.org/r/124957/diff/
> 
> 
> Testing
> -------
> 
> Tested using exports of investment accounts from Quicken 2013.
> 
> 
> Thanks,
> 
> Jeff Lundblad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160521/9d56ac84/attachment.html>