[kmymoney] [Bug 356399] crash while saving file after report change with data loss

Christian David via KDE Bugzilla bugzilla_noreply at kde.org
Thu Mar 24 21:00:09 UTC 2016


Christian David <christian-david at web.de> changed:

           What    |Removed                     |Added
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |5.0
      Latest Commit|                            |http://commits.kde.org/kmym
                   |                            |oney/8319120b9c810574beb0de
                   |                            |97fc44e49315de058d
         Resolution|---                         |FIXED

--- Comment #1 from Christian David <christian-david at web.de> ---
Git commit 8319120b9c810574beb0de97fc44e49315de058d by Christian Dávid.
Committed on 24/03/2016 at 20:30.
Pushed by christiand into branch 'frameworks'.

Changed way of saving files which should fix some bugs

The save operation seems to fail every time - it never changed the
orginal file and never reported any issues. I did not find the exact
reason for this bug but I am quite sure it was caused by an incorret
usage of QSaveFile (under some circumstances close() instead of commit()
was called).

Now KMyMoney creates its own temporary file to write to (if needed).
This also works using KGpgFile, which should fix Bug 356399.

The remove() and rename() operations are not atomic which is not so
good as this could result in dataloss if the first operation fails.
However, this is the best OS independet process I could find.

Errors during writing of compressed files may not be detected. I think
this issue should be fixed upstream.
REVIEW: 127108

M  +2    -2    CMakeLists.txt
M  +81   -82   kmymoney/views/kmymoneyview.cpp
M  +1    -5    kmymoney/views/kmymoneyview.h


You are receiving this mail because:
You are the assignee for the bug.

More information about the KMyMoney-devel mailing list