Review Request 127376: Improved kgpgfile's cmake file

Cristian Oneț onet.cristian at gmail.com
Tue Mar 15 12:59:28 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127376/#review93536
-----------------------------------------------------------


Ship it!




Tested on Windows, it looks good.

- Cristian Oneț


On Martie 14, 2016, 8:16 p.m., Christian David wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127376/
> -----------------------------------------------------------
> 
> (Updated Martie 14, 2016, 8:16 p.m.)
> 
> 
> Review request for KMymoney and Cristian Oneț.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Removed unnecessary commands. Added commands which might be needed.
> Patch is untested because I do not have access to an windows enviroment.
> 
> The changes are partly based on an inspection of https://quickgit.kde.org/?p=kdewin.git&a=blob&h=54d8881dd060cef58663854222187cdc01d2839d&hb=817dc9f454d2a65a7b80e203ab34052cd07294e8&f=cmake%2Fmodules%2FKDEWinConfig.cmake.in
> 
> KGpgfile should be KDE4support free.
> 
> Feel free not to answer to this review request for a long time. I just wanted to put it somewhere.
> 
> 
> Diffs
> -----
> 
>   libkgpgfile/CMakeLists.txt a41a6a408e3da8769308dae75d4f514aa969dc87 
> 
> Diff: https://git.reviewboard.kde.org/r/127376/diff/
> 
> 
> Testing
> -------
> 
> Compiled on Linux.
> 
> 
> Thanks,
> 
> Christian David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160315/9b6f1877/attachment.html>


More information about the KMyMoney-devel mailing list