Review Request 128247: Port CSV Importer slotFileDialogClicked to KF5

[Łukasz Wojniłowicz]

> On June 19, 2016, 12:18 p.m., Thomas Baumgart wrote:
> > How about moving those two (almost) identical parts into a method? Would that be possible?

It seems reasonable, but for now I don't want to change code structure too much, because I don't want to hit any unforseen bugs in process of porting. 
In general CSV Importer code is often duplicated here and there, and I think I will come with an genereal plan to rewrite, but in the future, if you don't mind.


> On June 19, 2016, 12:18 p.m., Thomas Baumgart wrote:
> > kmymoney/plugins/csvimport/csvdialog.cpp, line 614
> > <https://git.reviewboard.kde.org/r/128247/diff/1/?file=469265#file469265line614>
> >
> >     How about
> >     
> >     if(!m_inFileName.endswith(QDir::seperator))

Thanks, I'll do it that way.


> On June 19, 2016, 12:18 p.m., Thomas Baumgart wrote:
> > kmymoney/plugins/csvimport/csvdialog.cpp, line 617
> > <https://git.reviewboard.kde.org/r/128247/diff/1/?file=469265#file469265line617>
> >
> >     qDebug() << "Source:" << m_url.toDisplayStrin() << "Destination:" << m_inFilename;
> >     
> >     is a lot easier than using the 'old style' printf syntax.

It won't look as surrounding code, but that's ok.


- Łukasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128247/#review96708
-----------------------------------------------------------


On June 19, 2016, 10:08 a.m., Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128247/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 10:08 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> It makes "Select File" button usable again. I made native file dialogs forbidden, because they seem hard to customize for me at this point.
> 
> 
> Diffs
> -----
> 
>   kmymoney/plugins/csvimport/csvdialog.h 45586ff 
>   kmymoney/plugins/csvimport/csvdialog.cpp d14017b 
>   kmymoney/plugins/csvimport/investprocessing.h fe42429 
>   kmymoney/plugins/csvimport/investprocessing.cpp b266479 
> 
> Diff: https://git.reviewboard.kde.org/r/128247/diff/
> 
> 
> Testing
> -------
> 
> I loaded an my banking and investment statements.
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160619/fae8978d/attachment.html>