Review Request 127920: Use KAccountSelectDlg to select brokerage account

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127920/#review96195
-----------------------------------------------------------


Ship it!




Looks good to me, though future versions should not do too much user interaction during statement processing.

- Thomas Baumgart


On Juni 4, 2016, 9:05 nachm., Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127920/
> -----------------------------------------------------------
> 
> (Updated Juni 4, 2016, 9:05 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 363082
>     http://bugs.kde.org/show_bug.cgi?id=363082
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> During import of investment statement user is asked through simple input
> window to select brokerage account into which he wants to import. This
> patch changes input window to account selector.
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneystatementreader.h 80da202 
>   kmymoney/converter/mymoneystatementreader.cpp 6310f19 
> 
> Diff: https://git.reviewboard.kde.org/r/127920/diff/
> 
> 
> Testing
> -------
> 
> Imported my test csv file with investment statement.
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160605/62e1f7bc/attachment-0001.html>