Review Request 128411: Integrate tableWidget into CSVWizard

[Łukasz Wojniłowicz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128411/
-----------------------------------------------------------

(Updated July 23, 2016, 9:44 a.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney.


Repository: kmymoney


Description
-------

Result: [CSVWizard](http://i.imgur.com/ZkvSFce.png)
1) integrated tableWidget into CSVWizard,
2) removed separate window holding tableWidget,
3) modified some .ui files, so tableWidget gets the most space while resizing CSVWizard,
4) removed hardcoded values for HiDPI support; that functionality can be easier achieved with policies in QtDesigner
5) CSVWizar doesn't stay forever after import without setup,
6) tableWidget gets resized to fit content and not exceed screen area,
7) simplified completion page.

I think csvdialog.ui could be deleted as it isn't needed anymore.


Diffs
-----

  kmymoney/plugins/csvimport/bankingwizardpage.ui 95e5276 
  kmymoney/plugins/csvimport/csvdialog.h d226665 
  kmymoney/plugins/csvimport/csvdialog.cpp 4fff108 
  kmymoney/plugins/csvimport/csvimporterplugin.cpp b58ed84 
  kmymoney/plugins/csvimport/csvwizard.h 0bf1e59 
  kmymoney/plugins/csvimport/csvwizard.cpp 39bf9f2 
  kmymoney/plugins/csvimport/csvwizard.ui 5c42f46 
  kmymoney/plugins/csvimport/investmentdlg.cpp 514bff3 
  kmymoney/plugins/csvimport/investprocessing.h 15cba5e 
  kmymoney/plugins/csvimport/investprocessing.cpp e0d2b8f 

Diff: https://git.reviewboard.kde.org/r/128411/diff/


Testing
-------

Banking and investment statement CSV imports; with and without setup.


Thanks,

Łukasz Wojniłowicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160723/4eed96b6/attachment.html>