Review Request 128469: Skip to completion page when importing CSV without setup
Thomas Baumgart
tbaumgart at kde.org
Wed Jul 20 06:23:32 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128469/#review97642
-----------------------------------------------------------
Ship it!
I did a visual inspection only, no compile or even testrun. The patch looks good to me and seems to be related to the others provided by ?ukasz.
- Thomas Baumgart
On Juli 16, 2016, 5:14 nachm., Łukasz Wojniłowicz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128469/
> -----------------------------------------------------------
>
> (Updated Juli 16, 2016, 5:14 nachm.)
>
>
> Review request for KMymoney.
>
>
> Repository: kmymoney
>
>
> Description
> -------
>
> Just like when importing CSV with setup, completion page and not
> separator page should be the last one before actually importing the
> statement.
>
>
> Diffs
> -----
>
> kmymoney/plugins/csvimport/csvdialog.cpp 4fff108
> kmymoney/plugins/csvimport/csvwizard.h 0bf1e59
> kmymoney/plugins/csvimport/csvwizard.cpp 39bf9f2
> kmymoney/plugins/csvimport/investprocessing.cpp e0d2b8f
>
> Diff: https://git.reviewboard.kde.org/r/128469/diff/
>
>
> Testing
> -------
>
> Banking and investment statement CSV imports; with and without setup.
>
>
> Thanks,
>
> Łukasz Wojniłowicz
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160720/51548cd4/attachment.html>
More information about the KMyMoney-devel
mailing list