Review Request 126882: [Fixed Bug 275004] Changed to asynchronous download in converter/webpricequote using KIO::file_copy

[Artur Puzio]

> On Jan. 25, 2016, 4:33 p.m., Christian David wrote:
> > kmymoney/converter/webpricequote.cpp, line 157
> > <https://git.reviewboard.kde.org/r/126882/diff/2/?file=441567#file441567line157>
> >
> >     That is a nice trick to create a temporary file!

it's a copy-pasta from KIO sources.


> On Jan. 25, 2016, 4:33 p.m., Christian David wrote:
> > kmymoney/converter/webpricequote.h, line 184
> > <https://git.reviewboard.kde.org/r/126882/diff/2/?file=441566#file441566line184>
> >
> >     KUrl is depricated, should be ported to QUrl.

I chenged everywhere from KUrl->QUrl, but this exact line I removed as there is no silentDownload function in the end. We shouldn't introduce such function, becouse the download is assynchronous and the code used for download depends on other parts.


- Artur


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126882/#review91583
-----------------------------------------------------------


On Jan. 25, 2016, 5:12 p.m., Artur Puzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126882/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 5:12 p.m.)
> 
> 
> Review request for KMymoney and Christian David.
> 
> 
> Bugs: 275004
>     http://bugs.kde.org/show_bug.cgi?id=275004
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Changed to asynchronous download in converter/webpricequote using `KIO::file_copy`.
> The code in dialogs/kequitypriceupdatedlg was ideal to code this feature. The first download is triggered by `slotUpdateAllClicked`. Then the next downloads are trigered by signals from `WebPriceQuote`. This makes the ideal possibility to create assynchronous transfers as getting back to `slotUpdateAllClicked` immidietly after starting the job haven't broke anything.
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/webpricequote.h 01db54da0c7321e541579bd8ac14c480ef314898 
>   kmymoney/converter/webpricequote.cpp e97b71a3846b3cbf07ad7f88939495b8f47681d2 
> 
> Diff: https://git.reviewboard.kde.org/r/126882/diff/
> 
> 
> Testing
> -------
> 
> Autometed tests pass.
> The feature seams to be working. Even in case of an error the downloads continue. I teststed the funcionality when the "Update All" button is used.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160125/f19bda0f/attachment.html>