Review Request 126882: Changed to asynchronous download in converter/webpricequote using KIO::file_copy
Artur Puzio
cytadela88 at gmail.com
Mon Jan 25 14:56:20 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126882/
-----------------------------------------------------------
(Updated Jan. 25, 2016, 3:56 p.m.)
Review request for KMymoney and Christian David.
Changes
-------
Fixed a problem. Tested the code.
Repository: kmymoney
Description (updated)
-------
Changed to asynchronous download in converter/webpricequote using `KIO::file_copy`
The code in dialogs/kequitypriceupdatedlg was ideal to code this feature. The first download is triggered by `slotUpdateAllClicked`. Then the next downloads are trigered by signals from `WebPriceQuote`. This makes the ideal possibility to create assynchronous transfers as getting back to `slotUpdateAllClicked` immidietly after starting the job haven't broke anything.
Diffs (updated)
-----
kmymoney/converter/webpricequote.h 01db54da0c7321e541579bd8ac14c480ef314898
kmymoney/converter/webpricequote.cpp e97b71a3846b3cbf07ad7f88939495b8f47681d2
Diff: https://git.reviewboard.kde.org/r/126882/diff/
Testing (updated)
-------
Autometed tests pass.
The feature seams to be working. Even in case of an error the downloads continue. I teststed the funcionality when the "Update All" button is used.
Thanks,
Artur Puzio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160125/efd44de3/attachment.html>
More information about the KMyMoney-devel
mailing list