Review Request 126888: Fix locale conflict in kMyMoneyMoneyValidator

[Alexey Chernov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126888/
-----------------------------------------------------------

(Updated Feb. 24, 2016, 8:26 p.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney, Christian David and Cristian Oneț.


Changes
-------

Submitted with commit 615c72aff01fdb66601faedcc64f7cb5ed0035c0 by Alexey Chernov to branch frameworks.


Bugs: 358573
    http://bugs.kde.org/show_bug.cgi?id=358573


Repository: kmymoney


Description
-------

kMyMoneyMoneyValidator does all the locale-specific stuff of value validation by itself and relies on QDoubleValidator only to validate canonically formatted (i.e. "C" locale) value. Previously QDoubleValidator has a special case to always validate such values in spite of the system locale, but this seems to be removed in recent Qt5 versions. To return to the previous behaviour, "C" locale is set now explicitly. Generally it might be worth revisiting kMyMoneyMoneyValidator's code to possibly get rid of KDE4Support's KLocale type and use QDoubleValidator locale-specific validation facilities.


Diffs
-----

  kmymoney/widgets/kmymoneyedit.cpp c164ea8 

Diff: https://git.reviewboard.kde.org/r/126888/diff/


Testing
-------

Tested the "master" branch, with KF-5.18.0, Qt-5.5.1. Locale-specific decimal separator ("," in Russian locale) can now be successfully entered.


Thanks,

Alexey Chernov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160224/5521b9e0/attachment.html>