Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

[Artur Puzio]

> On Sty 25, 2016, 11:55 rano, Alvaro Soliverez wrote:
> > kmymoney/converter/mymoneystatementreader.cpp, line 1451
> > <https://git.reviewboard.kde.org/r/126875/diff/2/?file=439606#file439606line1451>
> >
> >     In this case, html tags could be added outside the i18n. By adding them within the statements, you're making strings fuzzy that translators will have to review and it could be avoided.
> >     It's not blocking, but if you have to modify the patch again, please keep it in mind.
> 
> Christian David wrote:
>     It will be fixed if I push the change.

I was just checking whats going on with my RR-s and fixed this :)


- Artur


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126875/#review91575
-----------------------------------------------------------


On Lut 24, 2016, 7:49 po południu, Artur Puzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126875/
> -----------------------------------------------------------
> 
> (Updated Lut 24, 2016, 7:49 po południu)
> 
> 
> Review request for KMymoney and Christian David.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Moved the question from `TransactionMatcher::match` to `MyMoneyStatementReader::askUserToEnterScheduleForMatching`.
> Added `MyMoneyTransaction & importedTransaction` parmeter to `MyMoneyStatementReader::askUserToEnterScheduleForMatching`, as `importedTransation` is required to calculate if the question from `TransactionMatcher::match` should be shown.
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneystatementreader.h 80da2023490a99963b5ff85c8d77cf1d8b58bf2b 
>   kmymoney/converter/mymoneystatementreader.cpp 1634bbb37ec86d0f065a73427cd353697812c79e 
>   kmymoney/dialogs/transactionmatcher.cpp 7d9740411b96940ac848009218dce65ffaac061e 
> 
> Diff: https://git.reviewboard.kde.org/r/126875/diff/
> 
> 
> Testing
> -------
> 
> Automated tests still pass, but they don't check the subject of work.
> Screenshot: [link](https://imgur.com/3Veh70N)
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160224/3124a4ab/attachment.html>