Review Request 126888: Fix locale conflict in kMyMoneyMoneyValidator

[Christian David]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126888/#review92723
-----------------------------------------------------------


Ship it!




Okay, I got it – our validator is a bit more complicated than needed. The request looks fine to me. Do you have the right to push the changes?

- Christian David


On Feb. 24, 2016, 12:11 p.m., Alexey Chernov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126888/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 12:11 p.m.)
> 
> 
> Review request for KMymoney, Christian David and Cristian Oneț.
> 
> 
> Bugs: 358573
>     http://bugs.kde.org/show_bug.cgi?id=358573
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> kMyMoneyMoneyValidator does all the locale-specific stuff of value validation by itself and relies on QDoubleValidator only to validate canonically formatted (i.e. "C" locale) value. Previously QDoubleValidator has a special case to always validate such values in spite of the system locale, but this seems to be removed in recent Qt5 versions. To return to the previous behaviour, "C" locale is set now explicitly. Generally it might be worth revisiting kMyMoneyMoneyValidator's code to possibly get rid of KDE4Support's KLocale type and use QDoubleValidator locale-specific validation facilities.
> 
> 
> Diffs
> -----
> 
>   kmymoney/widgets/kmymoneyedit.cpp c164ea8 
> 
> Diff: https://git.reviewboard.kde.org/r/126888/diff/
> 
> 
> Testing
> -------
> 
> Tested the "master" branch, with KF-5.18.0, Qt-5.5.1. Locale-specific decimal separator ("," in Russian locale) can now be successfully entered.
> 
> 
> Thanks,
> 
> Alexey Chernov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160224/60c0da1a/attachment.html>