[kmymoney4] [Bug 374352] Payee merge converts imported name containing string "Check" to existing Payee name "Check"

Thomas Baumgart bugzilla_noreply at kde.org
Sat Dec 31 12:14:39 UTC 2016


https://bugs.kde.org/show_bug.cgi?id=374352

Thomas Baumgart <tbaumgart at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---
     Ever confirmed|0                           |1

--- Comment #14 from Thomas Baumgart <tbaumgart at kde.org> ---
I might have to revert this last change by Lukasz because it changes the
behavior of the matching process and may break existing installations (mine as
well ;) ). I have not found all the details, but there was a reason for this
change back in Dec. 2008 (wow, we come a long way)

http://kmymoney2.cvs.sourceforge.net/viewvc/kmymoney2/kmymoney2/kmymoney2/converter/mymoneystatementreader.cpp?r1=1.62&r2=1.63&

on line 813. The checkin comment says

  Reworked matching logic so that in case of multiple payees match,
  the one with the largest match is taken. This returns the name
  matching to the 'old' functionality of partial matching.

and thus we wanted the 'partial matching' which Lukasz removed with his change.

A better solution to fix the problem here would be to setup the matching of
newly created entries to be exact which means to simply enclose them in ^ and $
and assign the MyMoneyPayee::matchKey method instead of MyMoneyPayee::matchName
in MyMoneyStatementReader::processTransactionEntry() where the
MyMoneyFile::addPayee parameters are constructed. This should solve the issue
as well w/o interfering existing databases.

I therefore reopen the tracker entry.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the KMyMoney-devel mailing list