Review Request 128874: Free QFileDialog memory

[Allan Anderson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128874/#review101573
-----------------------------------------------------------



Did you get a solution to this problem?  The reason I ask is that there is still a problem lurking in this area.
Having selected a profile, I then go to select the file to import. Having got to the file selector, if I then decide instead to reverse to get a different profile, I cancel the file selector and am returned to the intro profile screen.  If I cancel that too, when KMM is terminated, it aborts - Segmentation fault (core dumped).  I've spent quite a bit of time on this, making sure everything that should be deleted, is deleted, but don't yet have a solution.  As in this review, the Fileselect dialog is the crux, commenting it out avoids the abort.

- Allan Anderson


On Sept. 16, 2016, 4:38 p.m., Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128874/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 4:38 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> After closing CSV Importer in the middle and then KMyMoney, I get "The program has unexpectedly finished".
> The problem doesn't occur if CSV Importer goes all way through to the last page; then I can go back and close it wherever I want.
> If I comment out this line, there is no problem at all.
> ```c++
>   QPointer<QFileDialog> dialog = new QFileDialog(this, QString(),
>                                                  fileInfo.absoluteFilePath(),
>                                                  i18n("*.csv *.PRN *.txt | CSV Files\n *|All files"));
> ```
> Memory on which dialog pointed wasn't deleted in the method and it obviously need to be deleted, but the problem remains. Does anyone know how to prevent QtCreator from showing "The program has unexpectedly finished" here?
> 
> 
> Diffs
> -----
> 
>   kmymoney/plugins/csvimport/csvwizard.h ecec5b0 
>   kmymoney/plugins/csvimport/csvwizard.cpp b576dea 
> 
> Diff: https://git.reviewboard.kde.org/r/128874/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20161225/b539a073/attachment.html>