Review Request 128734: Rewrite intro page in CSV Importer

[Łukasz Wojniłowicz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128734/
-----------------------------------------------------------

Review request for KMymoney.


Repository: kmymoney


Description
-------

1) slotFileDialogClicked was duplicated in csvdialog.cpp and
investprocessing.cpp so moved it to csvwizard.cppp,
2) introduced getInFileName for asking user about his statement file,
3) createProfile, editProfileName, addProfileName was complicated and
replaced by single shorter profileTypeChanged
4) slotRadioButton_bankClicked and slotRadioButton_investClicked was
complicted and replaced by profileTypeChange
5) adding/removing/renaming profile was not user friendly and
informative so new buttons added,
6) no need to have template csvimporterrc, all can be done through
validateConfigFile
7) cleaned up csvimporterrc so its more informative and easier to get
data from it,
8) introduced updateConfigFile which is framework for migrating
csvimporterrc file between different KMM versions,
9) removed enableInputs as it wasn't doing anything usefull,
10) introduced m_config which allows asking for configuration file only
once at the beginning,
11) removed lots of redundant variables.


Diffs
-----

  kmymoney/plugins/csvimport/csvdialog.h ef7ba53 
  kmymoney/plugins/csvimport/csvdialog.cpp 859cdc2 
  kmymoney/plugins/csvimport/csvwizard.h cbc70fb 
  kmymoney/plugins/csvimport/csvwizard.cpp 3ff38ed 
  kmymoney/plugins/csvimport/introwizardpage.ui a91a737 
  kmymoney/plugins/csvimport/investprocessing.h 9374212 
  kmymoney/plugins/csvimport/investprocessing.cpp c306173 

Diff: https://git.reviewboard.kde.org/r/128734/diff/


Testing
-------


Thanks,

Łukasz Wojniłowicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160822/b605a0e1/attachment-0001.html>