Review Request 128725: Update price also for just created securities
Łukasz Wojniłowicz
lukasz.wojnilowicz at gmail.com
Mon Aug 22 05:11:15 UTC 2016
> On Aug. 21, 2016, 1:48 p.m., Thomas Baumgart wrote:
> > kmymoney/converter/mymoneystatementreader.cpp, line 726
> > <https://git.reviewboard.kde.org/r/128725/diff/1/?file=474805#file474805line726>
> >
> > Isn't this identical to
> >
> > currencyid = security.id();
Yes, it is wicked :) I could change it but it wont enhance the code.
- Łukasz
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128725/#review98525
-----------------------------------------------------------
On Aug. 20, 2016, 9:10 p.m., Łukasz Wojniłowicz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128725/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2016, 9:10 p.m.)
>
>
> Review request for KMymoney.
>
>
> Repository: kmymoney
>
>
> Description
> -------
>
> Security price should be updated from statement regardless of its previous existance in KMM.
>
>
> Diffs
> -----
>
> kmymoney/converter/mymoneystatementreader.cpp ad7505b
>
> Diff: https://git.reviewboard.kde.org/r/128725/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Łukasz Wojniłowicz
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160822/a05c6942/attachment.html>
More information about the KMyMoney-devel
mailing list