Review Request 128624: Rewrite processQIFLine

[Cristian Oneț]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128624/#review98230
-----------------------------------------------------------




kmymoney/plugins/csvimport/csvdialog.h (line 64)
<https://git.reviewboard.kde.org/r/128624/#comment66167>

    Why don't you name the enum and use the type everywhere that you added 'uchar' now?


- Cristian Oneț


On Aug. 7, 2016, 3:40 p.m., Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128624/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2016, 3:40 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> 1) processQIFLine should identify fields by integers and not strings (better performance),
> 2) validation of debit and credit column contained unnecessary check and was complicated,
> 3) QIF creation is not essential to processing,
> 4) statements is not needed and consumed memory exponentially,
> 5) cleaner hash assignation,
> 6) lots of redundant variables.
> 
> createMemoField is commented for now but won't be after I rewrite processInvestLine.
> 
> 
> Diffs
> -----
> 
>   kmymoney/plugins/csvimport/csvdialog.h 65bbeb7 
>   kmymoney/plugins/csvimport/csvdialog.cpp 6d91d63 
>   kmymoney/plugins/csvimport/csvwizard.h 2743685 
>   kmymoney/plugins/csvimport/csvwizard.cpp b042a98 
> 
> Diff: https://git.reviewboard.kde.org/r/128624/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160809/468a2f75/attachment.html>