Review Request 127712: Bug 360747 CSV Importer detects more columns than are assigned

[Łukasz Wojniłowicz]

> On April 27, 2016, 9:11 p.m., Cristian Oneț wrote:
> > kmymoney/plugins/csvimport/investprocessing.cpp, line 858
> > <https://git.reviewboard.kde.org/r/127712/diff/1/?file=456462#file456462line858>
> >
> >     Is this local variable really necessary?
> 
> Allan Anderson wrote:
>     I had noticed this.  Whilst it is used, I suspect that it could be replaced by m_parse, with possible minor adjustment, but I can't test, I'm afraid.

New parse isn't needed.
1) `m_columnList = m_parse->parseLine(data);` isn't used at all, so I deleted it,
2) `parseLine()` from csvutils.cpp doesn't modify `m_parse`, instead it returns `QStringList`,
3) it works for me if I use `m_parse` instead of `parse`.

I modified the patch. Thanks for good pointer.


- Łukasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127712/#review94911
-----------------------------------------------------------


On April 22, 2016, 8:56 p.m., Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127712/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 8:56 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 360747
>     http://bugs.kde.org/show_bug.cgi?id=360747
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Fixes bug #360747. Current routine doesn't calculate columns well when
> FieldDelimiter=DecimalSymbol. parseLine() from csvutil.cpp does it
> properly.
> 
> 
> Diffs
> -----
> 
>   kmymoney/plugins/csvimport/investprocessing.cpp 6826122 
> 
> Diff: https://git.reviewboard.kde.org/r/127712/diff/
> 
> 
> Testing
> -------
> 
> 1) CSV file where FieldDelimiter=DecimalSymbol=comma (Test file from bug #360747)
> 2) CSV file where FieldDelimiter=comma and DecimalSymbol=dot
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160428/2fd7907a/attachment.html>