Review Request 127680: Fix extends tags in .ui files that cause warnings when using the kmymoneywidgets.so plugin.

[Mitch Frazier]

> On April 26, 2016, 8:04 p.m., Christian David wrote:
> > I did not test it. Since ```KDialog``` is deprecated I am okay with this change. Also this was done for the frameworks branch already (which is important for me).
> 
> Mitch Frazier wrote:
>     This has the wrong diff (this is the diff for #127679).
> 
> Mitch Frazier wrote:
>     Trying to update the diff, but reviewboard says the file can't be parsed.  Ran into this problem before but have forgotten the workaround, will update when my memory returns...
> 
> Mitch Frazier wrote:
>     If memory serves me it's a known error with reviewboard.
>     
>     See https://www.mail-archive.com/reviewboard@googlegroups.com/msg15800.html for example:
>     
>     > There is a known issue with the tool when the branch isn't up-to-date with
>     > regard to its tracking branch. We're working on a set of improvements to this
>     > logic that will hopefully resolve this.
>     
>     But I've tried updating my repo and rebasing my branch, which is what I'm pretty sure fixed it the last time I had this problem.  But so far this hasn't fixed it...  Perhaps there are some bits caught in the Ether, I'll try it again later.
> 
> Mitch Frazier wrote:
>     Although the known problem above does produce the same error, this is a different variation: this appears instead to be due to the fact that the patch changes one of the same files that's included in the change for review request #127679, which has not yet been committed.
>     
>     If I try to add the patch to a new review request I get the following error from reviewboard:
>     
>         The specified diff file could not be parsed.
>         Line undefined: fatal: git cat-file 6e6a955d959a06b7aa0e30ba854a360f62b61fa3: bad file
>     
>     
>     If I do this:
>     
>         git cat-file -p 6e6a955d959a06b7aa0e30ba854a360f62b61fa3
>     
>     in my copy of the repo it shows me the file in question.  If I do it in a clean clone of the repo I get:
>     
>         fatal: Not a valid object name 6e6a955d959a06b7aa0e30ba854a360f62b61fa3
>     
>     I could attach the file directly or wait till a decision is made on #127679.
> 
> Cristian Oneț wrote:
>     @Christian David KDialog is only deprecated in frameworks, on KDE4 we should keep KDialog, that is why I asked against which branch is this pathch.

The KDialog change is actually #127679, the attached patch is actually for that review item.  That said, the change only changes KDialog to QDialog on the Qt Designer .ui files, the dialogs themselves continue to be KDialog.  The problem is that KDialog does not play well with Qt Designer and so if you open a KDialog .ui file in Qt Designer, it's all messed up and not very editable.

One of the things that I noticed was that most of the dialogs are defined as QDialog and have OK and Cancel buttons specifically added to them, perhaps because using KDialog causes problems with Qt Designer.

Going to copy these last few comments over to the other review item also.


- Mitch


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127680/#review94874
-----------------------------------------------------------


On April 22, 2016, 3 p.m., Mitch Frazier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127680/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 3 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Some custom-widgets specified the wrong class that was being
> extended by the widget causing warnings when opening the file
> with Qt Designer.
>     
> These warnings only occur when using the kmymoneywidgets.so plugin
> library for Qt Designer.
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/kcurrencycalculatordecl.ui 0bcfd4060338d8659979f8372269fba64f05c6ab 
>   kmymoney/dialogs/kcurrencyeditdlgdecl.ui 1527455a3201ba91c50bee572bc747bba59cd89a 
>   kmymoney/dialogs/kfindtransactiondlg.cpp 76030075141afe04a7aea23a06617be77cf1721d 
>   kmymoney/dialogs/kfindtransactiondlgdecl.ui 44fa86190d035c4652fa9b8129478f6cfcfd6d47 
>   kmymoney/dialogs/kmymoneypricedlgdecl.ui a484504c32f3313d1d6a37551be10f74485ec1d2 
>   kmymoney/dialogs/ksortoptiondlg.ui e7e28e588323b116c5874ad4ac3fee2c28663788 
>   kmymoney/dialogs/ksplitcorrectiondlg.ui fb6d337e746e7d2b5a9b5d355dae46a5dae369bc 
>   kmymoney/dialogs/ksplittransactiondlgdecl.ui 6b1c706a69ab0a289426fbd894068563dcf93e26 
> 
> Diff: https://git.reviewboard.kde.org/r/127680/diff/
> 
> 
> Testing
> -------
> 
> Tested a couple of the dialogs.
> 
> 
> Thanks,
> 
> Mitch Frazier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160427/97a76994/attachment.html>