Review Request 127679: Change .ui files that use KDialog as the dialog class to QDialog

[Mitch Frazier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127679/
-----------------------------------------------------------

(Updated April 22, 2016, 3 p.m.)


Review request for KMymoney.


Repository: kmymoney


Description
-------

KDialog does not work well with Qt Designer.

Changing the widget class from KDialog to QDialog is generally
all that's required.  Even though changing from KDialog to
QDialog does remove the OK and Cancel buttons in Designer,
these are added automatically because the dialog class itself
is still KDialog and it by default adds these buttons.

One of the dialogs did require the adding of a setButtons() call
to the constructor to place additional buttons on the dialog
that were previously specified in the .ui file.

Before and after screenshots show what the kfindtransactiondlgdecl.ui
file looks like in Qt Designer before with KDialog and after with QDialog.

Note that one of the dialogs, ksplittransactiondlgdecl.ui appears to
be unused and can probably be deleted, although I did not test that.


Diffs
-----

  kmymoney/dialogs/kcurrencycalculatordecl.ui 0bcfd40 
  kmymoney/dialogs/kcurrencyeditdlgdecl.ui 1527455 
  kmymoney/dialogs/kfindtransactiondlg.cpp 7603007 
  kmymoney/dialogs/kfindtransactiondlgdecl.ui 44fa861 
  kmymoney/dialogs/kmymoneypricedlgdecl.ui a484504 
  kmymoney/dialogs/ksortoptiondlg.ui e7e28e5 
  kmymoney/dialogs/ksplitcorrectiondlg.ui fb6d337 
  kmymoney/dialogs/ksplittransactiondlgdecl.ui 6b1c706 

Diff: https://git.reviewboard.kde.org/r/127679/diff/


Testing
-------

Tested the affected dialogs for correct look and function.


File Attachments
----------------

Before KDialog
  https://git.reviewboard.kde.org/media/uploaded/files/2016/04/17/84cb3eaf-fd0d-44c8-80a3-70fe3d6ba2b3__before-kdialog.png
After QDialog
  https://git.reviewboard.kde.org/media/uploaded/files/2016/04/17/eb4e6c79-c0d0-4d9b-8354-8e82f692cb90__after-qdialog.png


Thanks,

Mitch Frazier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160422/86890427/attachment.html>