[kmymoney4] [Bug 360435] CSV Importer doesn't recognize security if its symbol isn't lower case

NSLW via KDE Bugzilla bugzilla_noreply at kde.org
Sun Apr 17 17:55:52 UTC 2016


--- Comment #16 from NSLW <lukasz.wojnilowicz at gmail.com> ---
(In reply to allan from comment #15)
> Unfortunately, I am unable to follow the detail of the latest proposed
> patch, but I would like to urge some caution.  It may be that the proposal
> does not affect the config file - csvimporterrc, but in its current
> implementation, it is possible for the user to edit the entries in the file
> to suit his needs.  If instead the entries are moved into the coding, then
> recompilation would be required for any changes, which most users would not
> wish to face.  If this is not the case, then that's fine.

The second version of the patch is different from the first you've committed
only in asking m_map for security name using its symbol in uppercase instead of
lowercase, because m_map is from now on filled by default with symbols in
uppercase and m_map won't return correct name if asked in lowercase.

AFAIK no part of csvimporterrc shouldn't impact the behavior changed here. In
fact we make the behavior lax, so user can in any time change his symbol from
uppercase to lowercase or mixed case and still get it detected as the same

If that's fine I think I can apply second version of patch just like you've
applied the first one.

You are receiving this mail because:
You are the assignee for the bug.

More information about the KMyMoney-devel mailing list