[Kmymoney-devel] Review Request 123782: Renamed all .desktop files from kmymoney... to kmymoney-...

[Christian David]

> On Mai 14, 2015, 12:52 vorm., Alvaro Soliverez wrote:
> > kmymoney/payeeidentifier/nationalaccount/CMakeLists.txt, line 2
> > <https://git.reviewboard.kde.org/r/123782/diff/1/?file=368848#file368848line2>
> >
> >     This line is commented out. I don't think that's correct, is it?

Yep, you are right. That is a bad hack to disable this plugin – unfortunatly it is outdated already :'(


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123782/#review80319
-----------------------------------------------------------


On Mai 13, 2015, 10:39 nachm., Christian David wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123782/
> -----------------------------------------------------------
> 
> (Updated Mai 13, 2015, 10:39 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> The difference is the "-", this makes it more readable to humans. Also
> all files use the same standard now (packagers will thank us).
> 
> 
> Diffs
> -----
> 
>   kmymoney/payeeidentifier/nationalaccount/CMakeLists.txt e6d66d3a238ee507d4d29f730b6b20ab8927cdf8 
>   kmymoney/payeeidentifier/nationalaccount/kmymoneynationalaccountnumberplugin.desktop.in  
>   kmymoney/plugins/CMakeLists.txt 1a43470fc5ef7a365df9d266a5256f5d7638058a 
>   kmymoney/plugins/kmymoneyimporterplugin.desktop  
>   kmymoney/plugins/kmymoneyplugin.desktop  
> 
> Diff: https://git.reviewboard.kde.org/r/123782/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150514/18d7bd44/attachment-0001.html>