[Kmymoney-devel] Review Request 123177: Properly handle loan payments from accounts using a different currency

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123177/#review78213
-----------------------------------------------------------


Looks good to me. You have a 'ship it' after the change requested by me has been added.


kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp (line 283)
<https://git.reviewboard.kde.org/r/123177/#comment53587>

    use QLatin1String() here instead of QString()


- Thomas Baumgart


On März 29, 2015, 7:51 nachm., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123177/
> -----------------------------------------------------------
> 
> (Updated März 29, 2015, 7:51 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 325793
>     http://bugs.kde.org/show_bug.cgi?id=325793
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> If a payment account that has a different currency than the currency
> of the loan is selected in the loan wizard, the resulting scheduled
> transaction would not have the proper value in the currency of the
> payment account.
> 
> Fixed this by requesting the user to perform the currency conversion
> from the amount of the payment in the currency of the loan to the
> amount in the currency of the payment account. This conversion is done
> using the standard mechanism provided by the currency selector.
> 
> After this was fixed I observed that the amount of the scheduled
> transaction was not being rendered properly in the homepage. Fixed
> this by using the same amount formating that is used in the ledger.
> 
> BUG: 325793
> 
> 
> Diffs
> -----
> 
>   kmymoney/views/khomeview.cpp fac3343d17b0da47ad5a92cf9390658c87c6a420 
>   kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp 473defc58ac9d194c5fe2b8f0fd662025305ba82 
> 
> Diff: https://git.reviewboard.kde.org/r/123177/diff/
> 
> 
> Testing
> -------
> 
> Created multiple loans, seems to works as expected, although I still need to test loan editing.
> 
> The loan wizard has a few more bugs but I intend to file separate bug reports for those issues.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150330/d1605f31/attachment.html>