[Kmymoney-devel] Review Request 123154: Fix foreign currency income/expense transactions in reports.

[Cristian Oneț]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123154/
-----------------------------------------------------------

(Updated March 27, 2015, 5:29 p.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney.


Changes
-------

Submitted with commit 31adc38e7d632fb79eb3163998c8c568ee957383 by Cristian One? to branch master.


Bugs: 345550
    http://bugs.kde.org/show_bug.cgi?id=345550


Repository: kmymoney


Description
-------

Since commit [9fc583d3db4fe2c16448790d7ee17145fbe8bd2f](http://commits.kde.org/kmymoney/9fc583d3db4fe2c16448790d7ee17145fbe8bd2f) was added as a
fix for some currency conversions performed in reports income/expense
transactions which involved a currency conversion were not properly
displayed in the transactions by account report.

Extended the multi-currency report testcase to catch this error and
fixed the problem by resurrecting some conversion code which was
removed by that commit, but moved it to a place where it's applied
only to income/expense transactions.


Diffs
-----

  kmymoney/reports/querytable.cpp 974668a7923ee69cd88b63c15f6c061338916aa2 
  kmymoney/reports/querytabletest.cpp 008ccb724b5e35156100bd249f17d6d4d602cdee 

Diff: https://git.reviewboard.kde.org/r/123154/diff/


Testing
-------

Succesfully ran the newly added testcase and opened the file attached to BUG 345550, everything seems to work as it should now.


Thanks,

Cristian Oneț

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150327/bb5a54b0/attachment.html>