[Kmymoney-devel] Review Request 122746: Add a stage to the consistency check to fix transaction post dates.

[Cristian Oneț]

> On March 26, 2015, 7:23 a.m., Thomas Baumgart wrote:
> > kmymoney/mymoney/mymoneyfile.cpp, line 2152
> > <https://git.reviewboard.kde.org/r/122746/diff/3/?file=356601#file356601line2152>
> >
> >     I suggest you also leave the original date here as otherwise it will be gone and the user has no chance to revert to it by changing the opening dates of the accounts.

Good idea, I'll add that.


- Cristian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122746/#review78057
-----------------------------------------------------------


On March 25, 2015, 7:42 p.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122746/
> -----------------------------------------------------------
> 
> (Updated March 25, 2015, 7:42 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 313793
>     http://bugs.kde.org/show_bug.cgi?id=313793
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> If the transaction is moved to another post date the price information
> is moved along with it for investments transactions. This fixes the
> reported issue, saving the file once will fix all price issues.
> 
> Also add the possibility to save the consistency check log to a file
> or copy it into the clipboard.
> 
> Don't allow the user to add a transaction after the opening date of
> all accounts involved in the transaction.
> 
> BUG: 313793
> REVIEW: 122746
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/transactioneditor.cpp a215e3f8a1eaf2f7ccf1d73f29190f2ad86ff282 
>   kmymoney/kmymoney.h 92ab4b28d52c237222a2fb1106398ce0208215aa 
>   kmymoney/kmymoney.cpp c132983b63536e094375532082ea87c54461235c 
>   kmymoney/mymoney/mymoneyfile.cpp 8c1be4301a89b65f428edf2b8f0ab8b6e3dac51e 
> 
> Diff: https://git.reviewboard.kde.org/r/122746/diff/
> 
> 
> Testing
> -------
> 
> Opened the file attached to the report and observe that the consistency check fixes all of the issues.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150326/7fd1065a/attachment.html>