[Kmymoney-devel] Review Request 122138: [GCI2014] Find the maximum in a set of numeric strings.

Daniel Ring dring at g33kworld.net
Sat Jan 31 21:15:55 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 31, 2015, 9:15 p.m.)


This change has been marked as submitted.

Review request for KMymoney and Christian David.

Bugs: 339103

Repository: kmymoney


This adds a function to retrieve the highest ID number from the database. The IDs are prefixed by a short identifier string, and are stored in the database as strings.

This review request was created as a part of Google Code-In 2014. The specific task it refers to can be found here: https://www.google-melange.com/gci/task/view/google/gci2014/5774859095244800


  kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp 642fc53d9e220f34e463b2a27ab9a5d4b0c1e3ec 
  kmymoney/mymoney/storage/mymoneydbdriver.h e5fe0e9a0058dac1573b6b08087c93c74a06d9a6 
  kmymoney/mymoney/storage/mymoneydbdriver.cpp ab7449238bd55e3f4dc543790cd0f38eaa59d787 
  kmymoney/mymoney/storage/mymoneystoragesql.h 469c0f47d61df783f48787660f526fccdf5264a4 
  kmymoney/mymoney/storage/mymoneystoragesql.cpp fa9fbdf7d77eaa4922302d1f583317212af45ddf 
  kmymoney/mymoney/storage/mymoneydatabasemgrtest.h 07fc175cd9381ef0fc7ad314cf905c22a43fca81 

Diff: https://git.reviewboard.kde.org/r/122138/diff/


I created a small sample database with SQLite and verified that the SQL statment worked properly. I was able to successfully build and run KMyMoney with this function included in Debian Stable (using cmake from backports). However, I was unsure how best to test the function itself, so please let me know if any issues arise.


Daniel Ring

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150131/b98a06e4/attachment.html>

More information about the KMyMoney-devel mailing list