[Kmymoney-devel] [kmymoney4] [Bug 340656] The csv importer dialog display is broken on high DPI screens

[allan]

https://bugs.kde.org/show_bug.cgi?id=340656

--- Comment #17 from allan <agander93 at gmail.com> ---
The OP has now kindly tested my patch -
"
Hi Allan,

I managed to test your patch yesterday on a Fedora 20, on a 160 DPI
3200x1800 and the importer works much better, no more hidden buttons or
horked dialogs. I didn't notice any quirks but maybe I didn't look
attentively enough.

Thanks a lot!"

 BUG:340656 CSV Importer - Add capability to work on high-definition displays.
Fix interaction between the import preview table widget and the parameter entry
wizard, caused by them both resizing dynamically within the same window. This
was achieved by creating a new class and UI for the wizard and transferring 
most of the existing relevant code out of the large csvdialog.cpp file into the
new class and file.

- Apologies, especially to Cristian, for the size of this patch. -
( 16 files changed, 4030 insertions(+), 3492 deletions(-) )
    However, the net increase in size is only about 500 lines. and
    it becomes more easily maintainable.
So, am I to go via Reviewboard, bearing in mind the size and nature of this
change?
It's been tested on three different distros and three different screen ratios,
but not on Windows.

-- 
You are receiving this mail because:
You are the assignee for the bug.