[Kmymoney-devel] Review Request 121803: Changed label for serach bar in ledger from "Search" to "Filter"

[Thomas Baumgart]

Hi all,

first of all: Happy New Year!

Does this fix also need a change in the documentation?

Regards

Thomas



On Sunday 04 January 2015 16:40:47 you  wrote:
------------------------------------------------------------
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121803/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2015, 4:40 p.m.)
> 
> 
> Status
> ------
> 
> This change has been marked as submitted.
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 338296
>     http://bugs.kde.org/show_bug.cgi?id=338296
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> The field is actually more filter than search.
> 
> This also fixes the bug "In Ledger: Keyboard shortcut for Search (Alt-E)
> does not work".
> 
> I could not change the label in scheduled transactions view because it
> is hard coded in the library. But this should be done as well.
> 
> BUG: 338296
> FIXED-IN: 4.7.2
> REVIEW: 121803
> 
> Changed label for serach bar in scheduled transactions to "Filter"
> 
> Before is was "Search" but that is not correct.
> 
> REVIEW: 121803
> 
> 
> Diffs
> -----
> 
>   kmymoney/widgets/registersearchline.cpp
> cae7a3fa22bf5ccd559ebeefc12885bff8d1051d kmymoney/views/kscheduledview.cpp
> 2933bfc1f3d341b1d14122980da048004dd38902 kmymoney/widgets/CMakeLists.txt
> 4936827c0b13720be2fb547e2a1e0db8926939c9
> kmymoney/widgets/ktreewidgetfilterlinewidget.h PRE-CREATION
>   kmymoney/widgets/ktreewidgetfilterlinewidget.cpp PRE-CREATION
> 
> Diff: https://git.reviewboard.kde.org/r/121803/diff/
> 
> 
> Testing
> -------
> 
> Opened with english local and tested shortcut. Works fine.
> 
> 
> Thanks,
> 
> Christian David
-- 

Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-------------------------------------------------------------
If you've got friends that have you thrown out of a plane in mid-air,
you don't need enemies.
(Sebas Kügler on http://vizzzion.org/blog/2010/06/jumped/)
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 225 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150104/772574a9/attachment.sig>