[Kmymoney-devel] Review Request 121803: Changed label for serach bar in ledger from "Search" to "Filter"

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121803/#review73079
-----------------------------------------------------------



kmymoney/widgets/ktreewidgetfilterlinewidget.h
<https://git.reviewboard.kde.org/r/121803/#comment50834>

    Good idea to create a derived object.



kmymoney/widgets/ktreewidgetfilterlinewidget.cpp
<https://git.reviewboard.kde.org/r/121803/#comment50833>

    Why do you use a second translation item here? Doesn't using the same i18nc that is used in RegisterSearchLineWidget result in a single item? At least I thought it would, not sure though.


- Thomas Baumgart


On Jan. 4, 2015, 2:35 nachm., Christian David wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121803/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2015, 2:35 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 338296
>     http://bugs.kde.org/show_bug.cgi?id=338296
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> The field is actually more filter than search.
> 
> This also fixes the bug "In Ledger: Keyboard shortcut for Search (Alt-E)
> does not work".
> 
> I could not change the label in scheduled transactions view because it
> is hard coded in the library. But this should be done as well.
> 
> BUG: 338296
> FIXED-IN: 4.7.2
> REVIEW: 121803
> 
> Changed label for serach bar in scheduled transactions to "Filter"
> 
> Before is was "Search" but that is not correct.
> 
> REVIEW: 121803
> 
> 
> Diffs
> -----
> 
>   kmymoney/views/kscheduledview.cpp 2933bfc1f3d341b1d14122980da048004dd38902 
>   kmymoney/widgets/CMakeLists.txt 4936827c0b13720be2fb547e2a1e0db8926939c9 
>   kmymoney/widgets/ktreewidgetfilterlinewidget.h PRE-CREATION 
>   kmymoney/widgets/ktreewidgetfilterlinewidget.cpp PRE-CREATION 
>   kmymoney/widgets/registersearchline.cpp cae7a3fa22bf5ccd559ebeefc12885bff8d1051d 
> 
> Diff: https://git.reviewboard.kde.org/r/121803/diff/
> 
> 
> Testing
> -------
> 
> Opened with english local and tested shortcut. Works fine.
> 
> 
> Thanks,
> 
> Christian David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150104/9e397d60/attachment.html>