[Kmymoney-devel] Review Request 120499: Removed readFileInfo() and writeFileInfo() from upgradeToV7()

[Christian David]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120499/
-----------------------------------------------------------

(Updated Jan. 4, 2015, 2:07 p.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney.


Repository: kmymoney


Description
-------

MyMoneyStorageSql::upgradeToV7() does not use readFileInfo() and
writeFileInfo() anymore.

This should prevent an issue if this metod is used to upgrade the
database to a version higher than 7 as readFileInfo() and
writeFileInfo() assume a database of the most recent version. This
will cause errors (=> crash) if a column in kmmFileInfo was
renamed or added between version 7 and the final version.

KMyMoney should still crash if you upgradeToV1() is used.


Diffs
-----

  kmymoney/mymoney/storage/mymoneystoragesql.cpp 0fa790d435bc978279038893b945de31811f34f1 

Diff: https://git.reviewboard.kde.org/r/120499/diff/


Testing
-------

Opened an sqlite database which was created with KMyMoney 4.5.3, database version 6.
The upgrade still worked and kmmFileInfo was still filled with correct data.


Thanks,

Christian David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150104/95608af0/attachment.html>