[Kmymoney-devel] Review Request 122746: Add a stage to the consistency check to fix transaction post dates

[Cristian Oneț]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122746/
-----------------------------------------------------------

(Updated Feb. 27, 2015, 7:56 p.m.)


Review request for KMymoney.


Bugs: 313793
    http://bugs.kde.org/show_bug.cgi?id=313793


Repository: kmymoney


Description
-------

If the transaction is moved to another post date the price information
is moved along with it for investments transactions. This fixes the
reported issue, saving the file once will fix all price issues.

BUG:313793

Also fix some old code that added prices when entering transaction, there is no such action as "Sell".

BTW: currently it's possible to enter a transaction prior to the opening date of an account by making a transfer to that account from another account which has an older opening date, should we fix that?


Diffs
-----

  kmymoney/dialogs/transactioneditor.cpp 1aadc6fc96b7d21c7da198e92900023100fda9ad 
  kmymoney/mymoney/mymoneyfile.cpp 8c1be4301a89b65f428edf2b8f0ab8b6e3dac51e 

Diff: https://git.reviewboard.kde.org/r/122746/diff/


Testing
-------

Opened the file attached to the report and observe that the consistency check fixes all of the issues.


Thanks,

Cristian Oneț

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150227/868feb6b/attachment.html>