[Kmymoney-devel] Review Request 124957: Bug 351874 - QIF import of investment buys and sells mishandles commissions

[Jeff Lundblad]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124957/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 2:09 a.m.)


Review request for KMymoney.


Changes
-------

I should not have changed the sign on the quantity for a sell in the QIF reader.  The statement reader corrects it so the ledger was correct, but the code should be consistent: buy = negative amount, positive shares; sell = positive amount, negative shares.


Bugs: 351874
    http://bugs.kde.org/show_bug.cgi?id=351874


Repository: kmymoney


Description
-------

Changes made so that the commission for an investment buy or sell is only added to the transaction total one time instead of three times.


Diffs (updated)
-----

  kmymoney/converter/mymoneyqifreader.cpp d07b9b9 

Diff: https://git.reviewboard.kde.org/r/124957/diff/


Testing
-------

Tested using exports of investment accounts from Quicken 2013.


Thanks,

Jeff Lundblad

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150831/66cb8bc0/attachment.html>