[Kmymoney-devel] Review Request 124957: Bug 351874 - QIF import of investment buys and sells mishandles commissions

[Jeff Lundblad]

> On Aug. 30, 2015, 4:52 p.m., Thomas Baumgart wrote:
> > Changes to the MyMoneyStatementReader object also influence imports using other mechanisms than QIF like OFX and HBCI. Did you check that those changes don't affect them?

This patch breaks OFX import.  I'll need to do something else.  I can't test HBCI, but it looks like I need to do something that doesn't touch the statmemnt reader.  I think I just need to figure out what OFX passes to the statement reader and do the same from the QIF reader.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124957/#review84589
-----------------------------------------------------------


On Aug. 27, 2015, 9:38 p.m., Jeff Lundblad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124957/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 9:38 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 351874
>     http://bugs.kde.org/show_bug.cgi?id=351874
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Changes made so that the commission for an investment buy or sell is only added to the transaction total one time instead of three times.
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneyqifreader.cpp d07b9b9 
>   kmymoney/converter/mymoneystatementreader.cpp 1634bbb 
> 
> Diff: https://git.reviewboard.kde.org/r/124957/diff/
> 
> 
> Testing
> -------
> 
> Tested using exports of investment accounts from Quicken 2013.
> 
> 
> Thanks,
> 
> Jeff Lundblad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150830/9076c9c6/attachment.html>