[Kmymoney-devel] [kmymoney4] [Bug 347166] "Price/share" field on investment transaction entry form is mislabeled. Actually is total buy/sale amount.

[allan]

https://bugs.kde.org/show_bug.cgi?id=347166

--- Comment #15 from allan <agander93 at gmail.com> ---
On 26/08/15 00:02, Jack wrote:
> https://bugs.kde.org/show_bug.cgi?id=347166
>
> Jack <ostroffjh at users.sourceforge.net> changed:
>
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                   CC|                            |ostroffjh at users.sourceforge
>                     |                            |.net
>
> --- Comment #13 from Jack <ostroffjh at users.sourceforge.net> ---
> Allan - If I edit a transaction which imported as a Dividend, and switch it to
> Reinvestment Dividend, the label on that second field is blank, although it
> correctly uses the value I enter as total amount.  If I save the transaction,
> it correctly displays the price/share, and if I edit it again, it correctly
> displays it as Transaction amount.  Is there some other path through the code
> where you would need to set the label?
>

This is a common feature of both Buy and Sell, as well as Reinvest.  On 
opening a new transaction of any of these types, the Price field shows, 
but has no label.

In xxxxxx::ShowWidgets(), showing the Price label is controlled by 
Activity::havePrice(), which in turn depends on the presence of a price. 
  So the user has to first enter a price, but this isn't helped, for a 
new user, because of the absent label.  I can't see the purpose of 
Activity::havePrice() here, and it certainly isn't helpful.  The 
enabling of Enter is controlled by Activity::havePrice() anyway, and the 
entering of a price, so I would propose to remove it from the three 
ShowWidgets() methods of the activities that require a price.

In your particular use case, there is a further problem, however. 
Changing a Dividend transaction to a Reinvest, results in an unbalanced 
transaction, with a missing assignment.  This appears to be a hangover 
from your original Dividend transaction, so I'll need to see what's 
needed to remove that.

Allan

-- 
You are receiving this mail because:
You are the assignee for the bug.