[Kmymoney-devel] Review Request 124815: BUG:347166 "Price/share" field on investment transaction entry form is mislabeled

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124815/#review84041
-----------------------------------------------------------



kmymoney/dialogs/investactivities.cpp (line 206)
<https://git.reviewboard.kde.org/r/124815/#comment58215>

    Please use the defined constants (PricePerShare, PricePerTransaction, ...) here instead of hard coded values.
    
    Zero is not yet defined per constant, but it serves as 'Default', so you can also add a definition for it and fix the usage in InvestTransactionEditor::priceMode()



kmymoney/dialogs/investtransactioneditor.cpp (line 1144)
<https://git.reviewboard.kde.org/r/124815/#comment58214>

    This check is not needed anymore, as you removed the division by sharesEdit->value() in the next statement.


- Thomas Baumgart


On Aug. 19, 2015, 12:14 nachm., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124815/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2015, 12:14 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Fix for "Price/share" field on investment transaction entry form is mislabeled.
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/investactivities.h d2e2a76 
>   kmymoney/dialogs/investactivities.cpp 29c7957 
>   kmymoney/dialogs/investtransactioneditor.cpp 882e5a0 
> 
> Diff: https://git.reviewboard.kde.org/r/124815/diff/
> 
> 
> Testing
> -------
> 
> Create and edit numerous relevant transactions.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150819/6beca3b8/attachment.html>