[Kmymoney-devel] Review Request 122746: Add a stage to the consistency check to fix transaction post dates.

[Cristian Oneț]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122746/
-----------------------------------------------------------

(Updated Aprilie 6, 2015, 6:56 p.m.)


Review request for KMymoney.


Changes
-------

Fixed the issues that were raised.


Bugs: 313793
    http://bugs.kde.org/show_bug.cgi?id=313793


Repository: kmymoney


Description (updated)
-------

If the transaction is moved to another post date the price information
is moved along with it for investments transactions. This fixes the
reported issue, saving the file once will fix all price issues.

Also add the possibility to save the consistency check log to a file
or copy it into the clipboard.

Make sure that the user enters a valid transaction date by checking
that the transaction date is after the opening date of each and every
account involved in the transaction. Until now we only checked that
the transaction date is after the opening date of the account in which
is being entered.

Remove the check for "Sell" action since there is no such action.

BUG: 313793
REVIEW: 122746


Diffs (updated)
-----

  kmymoney/dialogs/transactioneditor.cpp a215e3f8a1eaf2f7ccf1d73f29190f2ad86ff282 
  kmymoney/kmymoney.h 92ab4b28d52c237222a2fb1106398ce0208215aa 
  kmymoney/kmymoney.cpp c132983b63536e094375532082ea87c54461235c 
  kmymoney/mymoney/mymoneyfile.cpp 8c1be4301a89b65f428edf2b8f0ab8b6e3dac51e 

Diff: https://git.reviewboard.kde.org/r/122746/diff/


Testing
-------

Opened the file attached to the report and observe that the consistency check fixes all of the issues.


Thanks,

Cristian Oneț

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150406/21dc20f2/attachment.html>