[Kmymoney-devel] Review Request 122746: Add a stage to the consistency check to fix transaction post dates.

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122746/#review78548
-----------------------------------------------------------



kmymoney/dialogs/transactioneditor.cpp (line 678)
<https://git.reviewboard.kde.org/r/122746/#comment53734>

    Why do you change 'Sell' to 'Add'? AFAIR, adding and removing shares does not involve a price. Please check by using the UI.



kmymoney/kmymoney.cpp (line 6978)
<https://git.reviewboard.kde.org/r/122746/#comment53732>

    In case MyMoneyFile::consistencyCheck() throws an exception, the assignment to m_consistencyCheckResult does not happen. Now appending a single line leaves the result with just that single line (m_consistencyCheckResult.size() == 1).
    
    I suggest to override alwaysDisplayResult with 'true' in this case to make sure that the user gets a notification about the problem. Since alwaysDisplayResult is false for those cases when the consistency check is run as part of any File/Save operation it is even more important to make sure that the user gets the information.



kmymoney/mymoney/mymoneyfile.cpp (line 2134)
<https://git.reviewboard.kde.org/r/122746/#comment53733>

    The logic does not implement a move but a copy of the price information since the old price information is not removed. Can we even move the price information or do we break other things in doing so?



kmymoney/mymoney/mymoneyfile.cpp (line 2138)
<https://git.reviewboard.kde.org/r/122746/#comment53735>

    Same as above about Add vs. Sell.


- Thomas Baumgart


On März 27, 2015, 7:29 vorm., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122746/
> -----------------------------------------------------------
> 
> (Updated März 27, 2015, 7:29 vorm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 313793
>     http://bugs.kde.org/show_bug.cgi?id=313793
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> If the transaction is moved to another post date the price information
> is moved along with it for investments transactions. This fixes the
> reported issue, saving the file once will fix all price issues.
> 
> Also add the possibility to save the consistency check log to a file
> or copy it into the clipboard.
> 
> Make sure that the user enters a valid transaction date by checking
> that the transaction date is after the opening date of each and every
> account involved in the transaction. Until now we only checked that
> the transaction date is after the opening date of the account in which
> is being entered.
> 
> BUG: 313793
> REVIEW: 122746
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/transactioneditor.cpp a215e3f8a1eaf2f7ccf1d73f29190f2ad86ff282 
>   kmymoney/kmymoney.h 92ab4b28d52c237222a2fb1106398ce0208215aa 
>   kmymoney/kmymoney.cpp c132983b63536e094375532082ea87c54461235c 
>   kmymoney/mymoney/mymoneyfile.cpp 8c1be4301a89b65f428edf2b8f0ab8b6e3dac51e 
> 
> Diff: https://git.reviewboard.kde.org/r/122746/diff/
> 
> 
> Testing
> -------
> 
> Opened the file attached to the report and observe that the consistency check fixes all of the issues.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150406/1fd83eb3/attachment.html>