[Kmymoney-devel] Review Request 120153: Remove the OFX investment transactions amount sign inversion hack.

Cristian Oneț onet.cristian at gmail.com
Fri Sep 12 12:16:19 UTC 2014



> On Sept. 12, 2014, 12:10 p.m., Allan Anderson wrote:
> > I've confirmed that when the OFX file (produced from the logfile) is imported into a checking account, the sign now is correct.
> > I've also imported a number of my own non-OFX files and they too are OK.
> > I'm not an OFX user, and I'm assuming that the second half of the file is informational and not for import.

Thanks, then somebody using OFX to import investment transactions should check this patch, anybody up fo the task?


- Cristian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120153/#review66338
-----------------------------------------------------------


On Sept. 12, 2014, 6:25 a.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120153/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2014, 6:25 a.m.)
> 
> 
> Review request for KMymoney and Allan Anderson.
> 
> 
> Bugs: 333522
>     http://bugs.kde.org/show_bug.cgi?id=333522
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> As the author of the hack states he's not sure why this was necessary.
> This hack also caused a lot of workarounds in MyMoneyStatementReader
> so it definitely should be removed. I've tried to keep the current
> behaviour in MyMoneyStatementReader but since I'm not familiar with
> investment transaction these should be double checked.
> 
> BUG: 333522
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneystatementreader.cpp 766d2151e17f07891f43e6d4d50861d40cbffe17 
>   kmymoney/plugins/ofximport/ofximporterplugin.cpp 556cb4195ef1c5680ac50ce394f8bd9893fdcbdb 
> 
> Diff: https://git.reviewboard.kde.org/r/120153/diff/
> 
> 
> Testing
> -------
> 
> Imported the OFX file attached to BUG 333522 in a checking account and in an investemnt account. Allan please take a look if the investment transactions part in MyMoneyStatementReader is OK.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140912/e40f7936/attachment.html>


More information about the KMyMoney-devel mailing list