[Kmymoney-devel] Review Request 120507: CSV Plugin - Improve functionality across distros. Improve UI to display the whole of the file being imported, and smarten to avoid displaying split rows. Also, rework some areas of the code to avoid duplication and improve re-usability.

[Allan Anderson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120507/
-----------------------------------------------------------

(Updated Oct. 16, 2014, 12:15 p.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney.


Repository: kmymoney


Description
-------

Improve functionality across distros.
It was also the intention to save the windows settings, but it was realised that there was a liklihood that the next file to be imported could have quite different column width and number of rows. So, it was decided to  display the whole of the file being imported instead.  
Also,the UI has been improved to avoid displaying split rows, with all possible rows being displayed, the window height aligning with the rows, and the width displaying complete columns, as far as the screen allowed.  Further, I reworked some areas of the code to avoid duplication and improve re-usability.


Diffs
-----

  kmymoney/plugins/csvimport/lines-datewizardpage.ui 884f3ba 
  kmymoney/plugins/csvimport/separatorwizardpage.ui b6dba9f 
  kmymoney/plugins/csvimport/bankingwizardpage.ui 0d6a4a8 
  kmymoney/plugins/csvimport/csvdialog.h 24abd9a 
  kmymoney/plugins/csvimport/csvdialog.cpp ab20ed4 
  kmymoney/plugins/csvimport/csvdialog.ui 61ab9ce 
  kmymoney/plugins/csvimport/csvimporterplugin.h d2d2f6c 
  kmymoney/plugins/csvimport/csvimporterplugin.cpp 602b4d9 
  kmymoney/plugins/csvimport/introwizardpage.ui a597d56 
  kmymoney/plugins/csvimport/investmentdlg.cpp 5e7b266 
  kmymoney/plugins/csvimport/investmentwizardpage.ui 846836e 
  kmymoney/plugins/csvimport/investprocessing.h fa8ffa0 
  kmymoney/plugins/csvimport/investprocessing.cpp 1629e14 

Diff: https://git.reviewboard.kde.org/r/120507/diff/


Testing
-------

Tested with numerous banking and investment files from different sources, on Linux Mint KDE and Ubuntu Unity.


Thanks,

Allan Anderson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20141016/3da63049/attachment.html>