[Kmymoney-devel] Review Request 118107: Calculate cleared balance in core

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118107/#review57833
-----------------------------------------------------------


I'll incorporate it as soon as possible in a updated version of https://git.reviewboard.kde.org/r/112885/ .

Thanks, Alvaro, for doing this job.

I'll also report back as soon as I can regarding speed.

- Marko Käning


On May 12, 2014, 10:53 p.m., Alvaro Soliverez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118107/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 10:53 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> It calculates cleared balance for an account in MyMoneyFile, instead of doing it in the ledger view (kgloballedgerview.cpp)
> 
> I'm posting it here because I'm a bit concerned on the performance it may have for everyday use.
> I'm keen on optimizing, but this kind of code should be removed from the views in the long-term.
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/mymoneyfile.h 3a39ba0 
>   kmymoney/mymoney/mymoneyfile.cpp 4f6d277 
>   kmymoney/views/kgloballedgerview.cpp d2d626c 
> 
> Diff: https://git.reviewboard.kde.org/r/118107/diff/
> 
> 
> Testing
> -------
> 
> I tested with a small file. It works ok. I still have to add a unit test for it.
> 
> 
> Thanks,
> 
> Alvaro Soliverez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140512/2b6f7bbe/attachment.html>