[Kmymoney-devel] Review Request 117630: Alkimia: Added a cmake package configuration file

[Christian David]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117630/
-----------------------------------------------------------

(Updated May 12, 2014, 5:49 p.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney and Skrooge.


Repository: alkimia


Description
-------

Added a cmake package configuration file

This replaces the Find....cmake file. A user should not notice any
    changes. But:

- CMAKE_PREFIX_PATH is honored now
- Users do not have to find GMP themselves (which was a bug)
- CMake users are not affected by a bug in PKG_CHECK_MODULES anymore
  more info: http://www.cmake.org/Bug/view.php?id=8644

This may not work if your old Find… file is still installed.

Also this should stop messing things up if you have several versions of alkimia installed (so annoying!).


Diffs
-----

  libalkimia/CMakeLists.txt 7676567 
  libalkimia/FindLibAlkimia.cmake 2c4ce1e 
  libalkimia/LibAlkimiaConfig.cmake.in PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117630/diff/


Testing
-------

Removed my systems FindLibAlkimia.cmake
Set CMAKE_PREFIX_PATH
make clean in KMyMoney
Compiled KMyMoney without setting ${GMP_LIBRARIES} anywhere in KMyMoney (=> it works)


Thanks,

Christian David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140512/d5a05949/attachment.html>