[Kmymoney-devel] [kmymoney] kmymoney: Changed splits icon

[Alvaro Soliverez]

Hi Allan,
You are right, I was missing the icon in the transaction form, which
is in a different class.


Regards,
Alvaro


On Sun, Mar 30, 2014 at 9:36 PM, Allan <agander93 at gmail.com> wrote:
> On 29/03/14 23:49, Alvaro Soliverez wrote:
>>
>> Git commit 6d9e913792216ee371f24bcde69afe822da94f5c by Alvaro Soliverez.
>> Committed on 06/03/2014 at 11:06.
>> Pushed by asoliverez into branch 'master'.
>>
>> Changed splits icon
>>
>> M  +1    -1    kmymoney/kmymoney.cpp
>>
>> http://commits.kde.org/kmymoney/6d9e913792216ee371f24bcde69afe822da94f5c
>>
>> diff --git a/kmymoney/kmymoney.cpp b/kmymoney/kmymoney.cpp
>> index 6b96b97..b4cf311 100644
>> --- a/kmymoney/kmymoney.cpp
>> +++ b/kmymoney/kmymoney.cpp
>> @@ -793,7 +793,7 @@ void KMyMoneyApp::initActions(void)
>>
>>     KAction *transaction_editsplits =
>> actionCollection()->addAction("transaction_editsplits");
>>     transaction_editsplits->setText(i18nc("Edit split button", "Edit
>> splits"));
>> -
>> transaction_editsplits->setIcon(KMyMoneyUtils::overlayIcon("view-financial-transfer",
>> "view-list-details"));
>> +  transaction_editsplits->setIcon(KIcon("split"));
>>     connect(transaction_editsplits, SIGNAL(triggered()), this,
>> SLOT(slotTransactionsEditSplits()));
>>
>>     KAction *transaction_cancel =
>> actionCollection()->addAction("transaction_cancel");
>>
>
>
> Hi Alvaro
>
> Having now looked at this change, I'm wondering if in fact it was a response
> to my query.
>
> The change appears to refer to the Transaction menu, but the icon I was
> referring to is the category split in the register.  The original was black
> and easily understood, whereas the new one is lacking in contrast for such a
> small icon, and the purpose is not clear, I feel.
>
> Allan