[Kmymoney-devel] Build system cleanup

[Cristian Oneț]

2014-07-21 14:39 GMT+03:00 Alvaro Soliverez <asoliverez at kde.org>:
> I'm all for it, the cmake buildfiles were put together back in KDE3
> days, and then hacked more and more during the port to KDE4, when KDE
> SC 4.4 was current.
>
> How do you propose to handle it?

I've been looking for some scripts that do this, found a few that can
take care of lowercase command naming and proper indentation [1], I
guess that the rest is up to us do to by hand. I can start working on
this but I thought we should discuss it first since this should also
go into master.

Regards,
Cristian

[1] https://github.com/Kitware/CMake/tree/master/Auxiliary

>
> Regards,
> Alvaro
>
> On Mon, Jul 21, 2014 at 4:50 AM, Cristian Oneț <onet.cristian at gmail.com> wrote:
>> Hi,
>>
>> While working with the build system files these days I've noticed that
>> there is a pretty big mess there. This is because the CMakeLists.txt
>> files didn't received that much attention since they were created back
>> in the KDE3 days when they existed alongside the automake build
>> system.
>>
>> I'm thinking that we should apply this coding style [1] which is used
>> in other parts of KDE. While looking at the CMake files of other
>> projects I've found this style to be more pleasant than what we have
>> now (with uppercase commands and a lack of uniform indentation).
>>
>> Any thoughts on this?
>>
>> Regards,
>> Cristian
>>
>> [1] https://techbase.kde.org/Policies/CMake_Coding_Style
>> _______________________________________________
>> KMyMoney-devel mailing list
>> KMyMoney-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/kmymoney-devel