[Kmymoney-devel] Review Request 119305: Add kmymoney to dependency data for kf5-qt5 branch group

[Marko Käning]

> On July 17, 2014, 6:39 a.m., Ben Cooksley wrote:
> > dependency-data-kf5-qt5, line 617
> > <https://git.reviewboard.kde.org/r/119305/diff/2/?file=290658#file290658line617>
> >
> >     Please use frameworks/kf5umbrella - which includes all Frameworks (incl. KActivities and the former parts of kdelibs - but not kdepimlibs)

Isn't this already covered by the following generic dep defined right after kf5umbrella:

# The generic dependency on all frameworks
kde/*: frameworks/kf5umbrella
extragear/*: frameworks/kf5umbrella

???

So, I guess simply deleting 2 lines should be it.


- Marko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119305/#review62540
-----------------------------------------------------------


On July 16, 2014, 11:05 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119305/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 11:05 p.m.)
> 
> 
> Review request for KMymoney, Ben Cooksley and Michael Pyne.
> 
> 
> Repository: kde-build-metadata
> 
> 
> Description
> -------
> 
> Herewith I intended to bring kmymoney to the OSX/CI system, but it is still also missing on the linux system for KF5...
> 
> 
> Diffs
> -----
> 
>   dependency-data-kf5-qt5 6819771be9eeddd37586570dd63b5fe9115c554e 
> 
> Diff: https://git.reviewboard.kde.org/r/119305/diff/
> 
> 
> Testing
> -------
> 
> It doesn't build yet, since I don't know how to handle the optional deps to frameworks Holidays, Gpgmepp and QGpgme.
> 
> Alkimia is still not building on OSX, though. (Its logical dependency structure already exists.) 
> 
> I'll post the problem on kmymoney-devel.
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140717/bae8f7d9/attachment-0001.html>