[Kmymoney-devel] Review Request 119305: Add kmymoney to dependency data for kf5-qt5 branch group
Cristian Oneț
onet.cristian at gmail.com
Wed Jul 16 05:08:58 UTC 2014
> On Iulie 16, 2014, 12:52 a.m., Michael Pyne wrote:
> > dependency-data-kf5-qt5, line 616
> > <https://git.reviewboard.kde.org/r/119305/diff/1/?file=290515#file290515line616>
> >
> > I'm assuming by "Holidays" you're referring to kdepimlibs, so that can be specified here (and appears to be a required, not optional, dependency):
> >
> > extragear/office/kmymoney: kde/kdepimlibs
> >
> > This would also take care of QGpgme.
> >
> > As far as Gpgmepp, that is a non-KDE dependency, isn't it? We only track KDE projects within this metadata file, external dependencies are required to be installed separately within the CI system.
>
> Marko Käning wrote:
> Ok, I thought that those 3 deps would be separate FWs.
Actually Gpgmepp is a KDE dependency since it's part of kdepimlibs https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/frameworks/entry/gpgme++/CMakeLists.txt#L54 so if kdepimlibs is really added as a dependency (btw I don see kdepimlibs here http://build.kde.org/job/kmymoney_frameworks_qt5/1/console) then it should build fine.
I hope the 'make the dependency optional' part will come but plese note that it's not yet committed. Anyway, even when it will it's still good to build with kdepimlibs present when possible.
- Cristian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119305/#review62454
-----------------------------------------------------------
On Iulie 16, 2014, 12:32 a.m., Marko Käning wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119305/
> -----------------------------------------------------------
>
> (Updated Iulie 16, 2014, 12:32 a.m.)
>
>
> Review request for KMymoney, Ben Cooksley and Michael Pyne.
>
>
> Repository: kde-build-metadata
>
>
> Description
> -------
>
> Herewith I intended to bring kmymoney to the OSX/CI system, but it is still also missing on the linux system for KF5...
>
>
> Diffs
> -----
>
> dependency-data-kf5-qt5 6819771be9eeddd37586570dd63b5fe9115c554e
>
> Diff: https://git.reviewboard.kde.org/r/119305/diff/
>
>
> Testing
> -------
>
> It doesn't build yet, since I don't know how to handle the optional deps to frameworks Holidays, Gpgmepp and QGpgme.
>
> Alkimia is still not building on OSX, though. (Its logical dependency structure already exists.)
>
> I'll post the problem on kmymoney-devel.
>
>
> Thanks,
>
> Marko Käning
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140716/ecd0eff6/attachment.html>
More information about the KMyMoney-devel
mailing list