[Kmymoney-devel] Review Request 119234: Transform KHolidays into an optional dependency.

[Alvaro Soliverez]

> On July 11, 2014, 7:58 p.m., Christian David wrote:
> > Is this only used until the pim libs are KF5 ready? Because I think this function is so important that it justifies having the pim libs a obligatory dependency. There will be many bug reports if a package maintainer forgets to compile with kdepimlibs.
> 
> Cristian Oneț wrote:
>     No, I would like to see this as a permanent change. I'm not that sure about which of the features are so important that they must be a mandatory dependency. I like the idea of having the freedom to build without kdepimlibs if necessary and if that can be obtained easily why not have it? I'm not sugesting that packagers should do this but for example in source based distributions users would be able to have a choice, which is nice.

I'm against this being a permanent change. It affects how schedules are handled, which impacts all over the application.
And I certainly don't want to track down a bug reported by an unsupecting user just to figure out later a packager left the dependency out because kde pim libs was "too big".


- Alvaro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119234/#review62153
-----------------------------------------------------------


On July 11, 2014, 7:58 p.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119234/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 7:58 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> If KDE PIM libraries will not be found during configuration all days will be considered processing days. Note that this review request dependes on the cmake changes in https://git.reviewboard.kde.org/r/119207/
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/settings/ksettingsschedules.cpp 96bfb84 
>   kmymoney/kmymoney.cpp 687187a 
> 
> Diff: https://git.reviewboard.kde.org/r/119234/diff/
> 
> 
> Testing
> -------
> 
> Build and run the application with and without HAVE_KDEPIMLIBS defined.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140711/99c40e32/attachment.html>