[Kmymoney-devel] Review Request 119234: Transform KHolidays into an optional dependency.

[Christian David]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119234/#review62153
-----------------------------------------------------------


Is this only used until the pim libs are KF5 ready? Because I think this function is so important that it justifies having the pim libs a obligatory dependency. There will be many bug reports if a package maintainer forgets to compile with kdepimlibs.

- Christian David


On Juli 11, 2014, 9:58 nachm., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119234/
> -----------------------------------------------------------
> 
> (Updated Juli 11, 2014, 9:58 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> If KDE PIM libraries will not be found during configuration all days will be considered processing days. Note that this review request dependes on the cmake changes in https://git.reviewboard.kde.org/r/119207/
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/settings/ksettingsschedules.cpp 96bfb84 
>   kmymoney/kmymoney.cpp 687187a 
> 
> Diff: https://git.reviewboard.kde.org/r/119234/diff/
> 
> 
> Testing
> -------
> 
> Build and run the application with and without HAVE_KDEPIMLIBS defined.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140711/b2e2aa68/attachment-0001.html>