[Kmymoney-devel] Review Request 119197: Add missing interdependency

[Vadim Zhukov]

2014-07-09 21:35 GMT+02:00 Vadim Zhukov <persgray at gmail.com>:
> 2014-07-09 20:31 GMT+02:00, Thomas Baumgart <tbaumgart at kde.org>:
>> Hi Vadim,
>>
>> maybe, the problem is already fixed with the add_dependencies statement
>> already present in the master branch and your addition is only needed in the
>> stable branch.
>
> Maybe, can't say for sure now.
>
>> So before I apply it, I let you investigate this a bit more.
>
> I'm finishing update KDE 4.13.2 update for OpenBSD as of now, and will
> be able to check master branch of KMyMoney tomorrow.

So I've build a KMyMoney a few times from master branch without any
problems. I think the problem is gone so the case could be closed.

>> When do you see the problem happening, because I have not seen it here in my
>> environment?
>
> Well, I just build KMyMoney, using Ninja backend (default on OpenBSD).
> In my experience, such races are often go unnoticed, especially in
> partial builds. And in case of Makefile backend there will are no
> problems usually due to straightforward ordering of compilation, even
> in the case of parallel compilation.
>
>> On Wednesday 09 July 2014 15:33:59 you  wrote:
>> ------------------------------------------------------------
>>> > On Июль 9, 2014, 7:18 п.п., Thomas Baumgart wrote:
>>> > > Does this solve the problem also? If you can confirm that, I am going
>>> > > to
>>> > > make the change.
>>> > >
>>> > > diff --git a/kmymoney/CMakeLists.txt b/kmymoney/CMakeLists.txt
>>> > > index acbc68d..12c8f50 100644
>>> > > --- a/kmymoney/CMakeLists.txt
>>> > > +++ b/kmymoney/CMakeLists.txt
>>> > > @@ -59,7 +59,7 @@ TARGET_LINK_LIBRARIES(kmymoney_common
>>> > >
>>> > >  # must build kmymoney/transactionsortoption.h
>>> > >  # from transactionsortoption.ui first
>>> > >  ADD_DEPENDENCIES(kmymoney_common generate_base_ui_srcs kmm_config)
>>> > >
>>> > > -ADD_DEPENDENCIES(wizardpages widgets)
>>> > > +ADD_DEPENDENCIES(wizardpages dialogs widgets)
>>> > >
>>> > >  SET( kmymoney_common_LIBS
>>> > >
>>> > >    views reports kmymoney_base kmymoney_common
>>>
>>> I think your patch is a Right Thing To Do.
>>>
>>> I'm limited to the stable release now (building fresh KDE packages for
>>> OpenBSD), which doesn't have the tweaked line at all, but if you need,
>>> I'll
>>> try to compile from source later today.
>>>
>>>
>>> - Vadim
>>>
>>>
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://git.reviewboard.kde.org/r/119197/#review61987
>>> -----------------------------------------------------------
>>>
>>> On Июль 9, 2014, 5:18 п.п., Vadim Zhukov wrote:
>>> > -----------------------------------------------------------
>>> > This is an automatically generated e-mail. To reply, visit:
>>> > https://git.reviewboard.kde.org/r/119197/
>>> > -----------------------------------------------------------
>>> >
>>> > (Updated Июль 9, 2014, 5:18 п.п.)
>>> >
>>> >
>>> > Review request for KMymoney.
>>> >
>>> >
>>> > Repository: kmymoney
>>> >
>>> >
>>> > Description
>>> > -------
>>> >
>>> > KMyMoney build (often) breaks with Ninja CMake backend due to missing
>>> > interdependency between targets. The patch below fixes that problem.
>>> >
>>> > Please note that I do not have commit rights.

--
  WBR,
  Vadim Zhukov